🤖 Prevent SSH workspace deletion with unpushed refs #460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add unpushed refs check to SSHRuntime.deleteWorkspace() - Only checks when git remotes are configured (no remote = no concept of unpushed) - Rejects deletion when unpushed commits exist unless force=true - Optimize: combine all pre-deletion checks into single bash script - Reduces SSH round trips from 5 to 2 (60% reduction) - Add tests for unpushed refs protection (force=false and force=true cases) Generated with `cmux`
- Extract SSH-specific unpushed refs tests into separate describe block - Removes conditional type checks inside tests (cleaner test structure) - Test output now clearly separates SSH-only tests from matrix tests - Follows same pattern as local-only submodule tests
ammario
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
SSH workspaces are independent git clones. Unlike local worktrees (which share
.git), deleting an SSH workspace with unpushed commits permanently loses that work. The deletion code only checked for uncommitted changes, not unpushed refs.Solution
Added unpushed refs check to
SSHRuntime.deleteWorkspace():force=falseforce=trueto proceedPerformance Optimization
Combined all pre-deletion checks into a single bash script to minimize SSH round trips:
Exit code mapping:
Testing
Added integration tests for SSH workspaces:
should fail to delete SSH workspace with unpushed refs without force flagshould delete SSH workspace with unpushed refs when force flag is setAll 16 deletion tests pass (9 local + 7 SSH).
Generated with
cmux